MRG: add --set-name to sig intersect and sig subtract
#3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #3162 +/- ##
=======================================
Coverage 86.67% 86.67%
=======================================
Files 136 136
Lines 15830 15832 +2
Branches 2716 2716
=======================================
+ Hits 13720 13722 +2
Misses 1800 1800
Partials 310 310
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…h into provide_name_on_sig
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ctb
changed the title
--name to sig intersect and sig subtract--set-name to sig intersect and sig subtract
|
ready for review @sourmash-bio/devs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: PR into #3161
This PR cleans up and regularizes naming output on
sigsubcommands. Specifically, it:--set-nametosig intersectandsig subtractto set names on output signatures.sig inflate,sig filter,sig downsample, andsig flatten--nameto--set-nameonsig merge, and nominates--namefor deprecation and removal on v5--nameonsig extract,sig filter, andsig flattenfor deprecation and removal on v5--nameonsketch dna,sketch protein, andsketch translate- refsketch...--nameis not documented in CLI help #3152Fixes #1801
Fixes #3152
Related issues:
--nameonsigsubcommands #3173