-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dev env instructions #2990
base: latest
Are you sure you want to change the base?
Conversation
e60ea44
to
f759c17
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #2990 +/- ##
=======================================
Coverage 86.88% 86.88%
=======================================
Files 136 136
Lines 15543 15543
Branches 2637 2637
=======================================
Hits 13505 13505
Misses 1736 1736
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9cd3fec
to
1878403
Compare
I mean I've loved pixi, the little bit I've used it; but do we really want to switch dev instructions over to it? |
(I guess I'm not immediately seeing a big reason. But I am happy to be convinced :) |
We have the drift on install instructions (as pointed in #2707) because what we document is not quite we run in CI. I was going for setting up pixi and using the It is still fine to have conda instructions and say "look at the
I like pixi because it is so much easier to install than conda, and doesn't mess with shell env vars. And if you're in a system that has conda installed but doesn't allow extra software installation, you can still Drawback is that conda is much more stable, pixi has been moving pretty quickly and might be hard to keep up (but we do have CI setup in this PR). It boils down to which is the easiest one to teach and get started, pixi seems easier because it's one file to download and All that said, I don't use conda or pixi for sourmash development, so better to someone that does use to chime in 🙃 |
new features, running tests and code quality checks. | ||
Here are some suggestions on how to set them up (note: you only need one =]) | ||
|
||
### Using mamba (conda alternative) | ||
::::{tab-set} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How the tabs look like: https://sourmash--2990.org.readthedocs.build/en/2990/developer.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it!
1501abf
to
6e8ffff
Compare
Close #2793
dev.yml
with dev dependencies