Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/proxy latency #9489

Merged
merged 22 commits into from
May 21, 2024
Merged

Docs/proxy latency #9489

merged 22 commits into from
May 21, 2024

Conversation

nfuden
Copy link
Contributor

@nfuden nfuden commented May 15, 2024

Update proxy latency documentation to note what is actually emitted.

Also note the new upstream access logger as many users are curious about access logger usage for latency
BOT NOTES:
resolves #9317

@nfuden nfuden requested a review from a team as a code owner May 15, 2024 14:21
@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label May 15, 2024
@nfuden
Copy link
Contributor Author

nfuden commented May 15, 2024

/skip-ci

Copy link

github-actions bot commented May 15, 2024

Visit the preview URL for this PR (updated for commit 9d95a95):

https://gloo-edge--pr9489-docs-proxy-latency-1k6v2exk.web.app

(expires Tue, 28 May 2024 19:07:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@solo-changelog-bot
Copy link

Issues linked to changelog:
#9317

@nfuden
Copy link
Contributor Author

nfuden commented May 16, 2024

/kick consul

Copy link
Contributor

@Rachael-Graham Rachael-Graham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs suggestions

sam-heilbron
sam-heilbron previously approved these changes May 17, 2024
@nfuden
Copy link
Contributor Author

nfuden commented May 21, 2024

/skip-ci

@soloio-bulldozer soloio-bulldozer bot merged commit 055d85a into main May 21, 2024
25 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the docs/proxy-latency branch May 21, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxy_latency_response_out is always equal to DURATION time of the request
4 participants