Create Spree::SimpleOrderContents #5755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_core
mamhoff
force-pushed
the
simple-order-contents
branch
2 times, most recently
from
8e9306b
to
1900daa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5755 +/- ##
==========================================
+ Coverage 88.87% 88.89% +0.01%
==========================================
Files 708 709 +1
Lines 16825 16843 +18
==========================================
+ Hits 14953 14972 +19
+ Misses 1872 1871 -1 ☔ View full report in Codecov by Sentry. |
Spree::OrderContents interacts heavily with the current promotion system. This adds a new `Spree::SimpleOrderContents` class that we can use once all the core functionality and specs for the legacy promotion system are migrated to `solidus_legacy_promotions`. We're keeping `Spree::OrderContents` though, with the intention of moving it to `solidus_legacy_promotions` in the future.
mamhoff
force-pushed
the
simple-order-contents
branch
from
1900daa
to
efcbcac
Compare
|
Rebased from main |
There were two uncovered lines, and this adds coverage for those lines.
mamhoff
force-pushed
the
simple-order-contents
branch
from
10363ee
to
6415b7f
Compare
tvdeyen
approved these changes
May 23, 2024
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Jun 5, 2024
With the null promotion configuration in place, we can't use the legacy Spree::OrderContents class, as that makes references to the legacy promotion system. See solidusio#5755
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Jun 6, 2024
With the null promotion configuration in place, we can't use the legacy Spree::OrderContents class, as that makes references to the legacy promotion system. See solidusio#5755
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Jun 6, 2024
With the null promotion configuration in place, we can't use the legacy Spree::OrderContents class, as that makes references to the legacy promotion system. See solidusio#5755
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Spree::OrderContents interacts heavily with the current promotion system. This adds a new
Spree::SimpleOrderContentsclass that we can use once all the core functionality and specs for the legacy promotion system are migrated tosolidus_legacy_promotions.We're keeping
Spree::OrderContentsthough, with the intention of moving it tosolidus_legacy_promotionsin the future.Extracted from #5634
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: