New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Athena catalog column name to default #1888
Open
bichitra95
wants to merge
7
commits into
sodadata:main
Choose a base branch
from
atlanhq:main
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: column_metadata_catalog_column method to default value for Athena
Kudos, SonarCloud Quality Gate passed! |
fix databricks datatype cast and support for int type decimal
Databricks: Profiling support for bigint datatypes
Kudos, SonarCloud Quality Gate passed! |
Thanks for reporting and fixing this @bichitra95 ! I apologize for the delay, this has slipped our attention for too long. Would you be able to resolve the conflicts please so that we can merge this? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #1887
While profiling for a table, we are fetching the columns metadata for the table here.
The query that generates for fetching the columns is of follows,
So removed the override method to use the parent method which returns
table_catalog
instead oftable_schema
.