View without Activity #329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow mosby to support view without activity
|
Build failed due to api 28: "Failed to install the following Android SDK packages as some licences have not been accepted." |
sockeqwe
reviewed
Mar 25, 2019
| * A android.view.View can added (in)directly to a Activity or a WindowManager, | ||
| * in which case only destroy Presenter is needed, not release | ||
| */ | ||
| boolean isViewOnActivity(); |
There was a problem hiding this comment.
How is this intended to work? It should return false if used without activity?
There was a problem hiding this comment.
Thanks. I will make it more explicit
|
Hey @bdelville I was wondering if it make sense to keep this outside of the library? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow mosby to support view without activity:
Reference ticket: #281
Alternatively, we can just remove the Exception when there is no activity and switch automatically to Window-mode for ViewGroup base DelegateCallback. But I guess if we add this feature we would like it to be enforced and managed.
So the user will need to implement "public boolean isViewOnActivity()"
It basically switch to a mod where it does not expect to save a state nor detach a view without destroying.
From a user perspective, a CustomView can be use alternatively by a Activity or a Window directly, an easy way to support that would be to implement:
public boolean isViewOnActivity() { return PresenterManager.getActivity(delegateCallback.getContext()) != null }