Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding G10 and C11 intrinsic scattering models #378
base: master
Are you sure you want to change the base?
adding G10 and C11 intrinsic scattering models #378
Changes from 18 commits
a7ac69b
6558af3
1eea86e
b6cedd9
c85fe40
b265691
e211155
9ef280e
d741c9e
28ea5e0
38a8ead
6eae0a0
e05557e
f2209bb
4883594
315bf38
f30afbc
91f8428
3beb6c4
63b56b9
252a473
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would moving this to
__init__
make thisSALTwithG10.bandflux
the same on repeated calls?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it should works since the random part is in
self.compute_sigma_nodes()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving this part in
__init__
leads to a non-functionalModel.set()
since the updates onself._parameters
will not be taken into account. I set aself._seed
parameter in the__init__
to fix the randomness when init the model.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these first three statements could be moved to
__init__
. Am I missing something?