GOTO #374
Merged
GOTO #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for merging @benjaminrose. I hope this one is now good to go. |
|
Yeah, sorry for the delay. My one question: GOTO is not a common telescope/acronym, I wonder if we should use the full name for |
|
@benjaminrose could do, although then shouldn't we have done that for atlas / panstarrs/ ztf and everything else? |
|
Yes, this matches what is done elsewhere, so is viable. But Atlas, panSTARRS and ZTF are all very common surveys. Let's leave it as is, and people can go to Again, sorry for being a bit slow. I was traveling last week and the second PR slipped through the cracks. |
|
Thanks @benjaminrose! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds GOTO as a builtin bandpass (important given they are publicly announcing candidates in their filter set).