Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roimethstat and order of chromosomes #8

Open
andrewdavidsmith opened this issue Jul 8, 2022 · 2 comments
Open

roimethstat and order of chromosomes #8

andrewdavidsmith opened this issue Jul 8, 2022 · 2 comments

Comments

@andrewdavidsmith
Copy link
Collaborator

It seems roimethstat has problems when the chromosomes are not in the same order between the methylation file and the regions file.

@andrewdavidsmith
Copy link
Collaborator Author

This likely arises because the entire data set is processed as a single vector with all chromosomes together. Separating the chroms, as long as they are in correspondence when processed, will circumvent this problem.

@andrewdavidsmith
Copy link
Collaborator Author

Candidate solution: modify the regions_bounds function so that it takes iterators, or at least a start and end index for the range. Then, when loading the methylation data, keep some index for the start and end of each chromosome's sites within the vector. Before looking for the appropriate bounds for any given region, first make sure to be searching within the appropriate bounds among the sites. Then the order of chroms will not matter, but the chroms must still be together and the sites must still be sorted (or all bets are off).

@andrewdavidsmith andrewdavidsmith transferred this issue from smithlabcode/methpipe Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant