Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectsites failing with poor message on unsorted sites processed on disk #123

Open
andrewdavidsmith opened this issue Aug 31, 2023 · 0 comments

Comments

@andrewdavidsmith
Copy link
Collaborator

Describe the bug
When the sites are not pre-loaded they need to have a very specific order on the chromosomes and this is not made clear to the user. In addition, the message about forcing pre-laoded sites when the input is compressed is not sensible.

To Reproduce
Steps to reproduce the behavior:
Do selectsites with an order on chromosomes that puts, e.g., chr10 before chr1. This will fail without a reasonable error message unless the sites are pre-loaded.

Expected behavior
And error message should indicate the required order when sites are processed on disk. Better: the order of sites may be determined by a quick scan of the input file to find the chromosome order, so that the only sorting strictly required would be within chromosomes.

Desktop (please complete the following information):

  • OS: Ubuntu 22.
  • Version: 1.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant