Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/chains/evm/config/toml/defaults: remove ineffectual overrides #13243

Merged
merged 1 commit into from
May 28, 2024

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented May 17, 2024

This PR proposes removing redundant/ineffectual overrides from the evm configs. I left a few behind which had long comments about lack of support, so that we don't accidentally change them.

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@jmank88 jmank88 marked this pull request as ready for review May 17, 2024 12:57
@jmank88 jmank88 requested a review from a team as a code owner May 17, 2024 12:57
@jmank88 jmank88 requested a review from dimriou May 17, 2024 12:57
@jmank88 jmank88 enabled auto-merge May 17, 2024 12:57
Copy link
Collaborator

@dhaidashenko dhaidashenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
TestFunctionsConnectorHandler fails, but it seems to be a flake not caused by the changes

Copy link
Contributor

@prashantkumar1982 prashantkumar1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 1 minor comment

@@ -2,32 +2,19 @@
# Clique offers finality within (N/2)+1 blocks where N is number of signers
# There are 21 BSC validators so theoretically finality should occur after 21/2+1 = 11 blocks
ChainID = '56'
# Keeping this >> 11 because it's not expensive and gives us a safety margin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this comment ought to remain, to show why we chose to go with eth's depth for BSC too?

@jmank88 jmank88 added this pull request to the merge queue May 28, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Merged via the queue into develop with commit 25173fb May 28, 2024
105 of 106 checks passed
@jmank88 jmank88 deleted the ineffectual-overrides branch May 28, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants