Add start end end to the TextHorizontalAlignment #4550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTL languages are not supported yet though, but once they will it will be usefull
|
The idea is that people would start now by using the right value for the enum even if it doesn't work yet. |
tronical
approved these changes
Feb 6, 2024
| @@ -22,6 +22,12 @@ macro_rules! for_each_enums { | |||
| $macro element. | |||
| enum TextHorizontalAlignment { | |||
| /// The text will be aligned with the start edge of the containing box. | |||
| /// This could be left or right depending on the direction of the text in the language. | |||
There was a problem hiding this comment.
Suggested change
| /// This could be left or right depending on the direction of the text in the language. | |
| /// This could be left or right depending on the direction of the text. |
| /// This could be left or right depending on the direction of the text in the language. | ||
| Start, | ||
| /// The text will be aligned with the end edge of the containing box. | ||
| /// This could be left or right depending on the direction of the text in the language. |
There was a problem hiding this comment.
Suggested change
| /// This could be left or right depending on the direction of the text in the language. | |
| /// This could be left or right depending on the direction of the text. |
| @@ -97,9 +97,13 @@ pub fn create_layout( | |||
| } | |||
|
|
|||
| style.set_text_align(match h_align { | |||
| items::TextHorizontalAlignment::Left => skia_safe::textlayout::TextAlign::Left, | |||
| TextHorizontalAlignment::Start | items::TextHorizontalAlignment::Left => { | |||
There was a problem hiding this comment.
I think start should be mapped to skia_safe::textlayout::TextAlign::Start; same for end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTL languages are not supported yet though, but once they will it will be usefull