fix: Twoslash popover displayed in wrong place #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
KermanX
commented
May 16, 2024
|
|
||
| #twoslash-container .v-popper__wrapper { | ||
| transform: scale(calc(1 * var(--slidev-slide-scale))); | ||
| transform-origin: 30px top; |
There was a problem hiding this comment.
This is an approximation. There is an arrow newar the left top of the popover, which should align the center of the code token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1593.
This is only a simple workaround. The root fix may requires a rewrite/fork of the Twoslash renderer, which will also make #1414 fixed).
Also tested in print mode.