Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support read-only publish service #11367

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from

Conversation

Zuoqiu-Yingyi
Copy link
Contributor

  • Please commit to the dev branch
  • For contributing new features, please supplement and improve the corresponding user guide documents

REL: #11364

添加设置项 | Add setting items

{
  "publish": {
    "enable": true,
    "port": 6808,
    "auth": {
      "enable": true,
      "accounts": [
        {
          "username": "1",
          "password": "1",
          "memo": "这是用户 1"
        },
        {
          "username": "2",
          "password": "2",
          "memo": "这是用户 2"
        }
      ]
    }
  }
}

siyuan.config.publish.enable: 是否开启发布服务
siyuan.config.publish.port: 自定义发布服务端口, 设置为 0 则使用随机端口
siyuan.config.publish.auth.enable: 发布服务是否启用 BasicAuth 认证
siyuan.config.publish.auth.accounts: 发布服务 BasicAuth 认证账户列表

已经过测试 | TESTED

@zxhd863943427
Copy link
Contributor

casbin这个库对权限管理是否有帮助?

@Zuoqiu-Yingyi
Copy link
Contributor Author

casbin这个库对权限管理是否有帮助?

目前没有多用户, 只需要基于角色的访问控制, 感觉用不太上👀

@Zuoqiu-Yingyi
Copy link
Contributor Author

Zuoqiu-Yingyi commented May 13, 2024

@88250
目前该功能差不多了, 不过还有如下几点问题不太好处理, 如果这些问题可忽视的话就可以开始合并的工作了

  • getGraph 等 API 会更改 model.Conf 并更改 conf.json 文件

@88250
Copy link
Member

88250 commented May 13, 2024

收到,打算放到特性版本 v3.1.0 中合并。

@88250 88250 added this to the 3.1.0 milestone May 13, 2024
@Zuoqiu-Yingyi
Copy link
Contributor Author

收到,打算放到特性版本 v3.1.0 中合并。

顺便检查一下 API 的鉴权中间件设置的是否合理, 因为没有逐项检查, 可能有不合理的地方

@Zuoqiu-Yingyi
Copy link
Contributor Author

还有就是前端的设置面板与该功能相关的设置 API 可能需要之后由 @Vanessa219 实现一下

@88250
Copy link
Member

88250 commented May 13, 2024

初步看了下,还缺失配置部分和用户指南文档,你后面有空的话先把这两部分补齐吧。

@Zuoqiu-Yingyi
Copy link
Contributor Author

Zuoqiu-Yingyi commented May 16, 2024

@88250 @Vanessa219

  • 内核发布服务
  • 访问控制系统
  • 发布服务设置 API
  • 发布服务设置界面
  • 发布服务用户指南

@88250
Copy link
Member

88250 commented May 17, 2024

收到,改得有点多,审核会比较慢,谢谢。

@88250 88250 changed the title Kernel supports read-only publishing services Support read-only publish service May 17, 2024
@TCOTC
Copy link
Contributor

TCOTC commented May 19, 2024

image

这两个地方要引用一下新增的文档(3个用户指南都要):

image

image

@Zuoqiu-Yingyi
Copy link
Contributor Author

收到,改得有点多,审核会比较慢,谢谢。

那我先暂不解决合并冲突了, 因为出现得太频繁了, 等合并前再集中解决

@88250
Copy link
Member

88250 commented May 27, 2024

明天发布 v3.0.16,发布后如果没有严重问题,后面的版本就是 v3.1.0 了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants