add functionality to disable direct upload to cache

osp/app/dependencies.py

@@ -119,6 +119,11 @@ def depends_upload(
     return _get_upload(temp.name, uuid, minio_client)
 
 
+def depends_upload_enabled(config: AppConfig = Depends(get_appconfig)) -> bool:
+    """Check whether direct upoad to data cache is enabled or not"""
+    return config.enable_upload
+
+
 def depends_download(
     dataset_name: str = Query(..., title="Cache ID received after the upload."),
     minio_client: Minio = Depends(depends_minio),

osp/app/main.py

@@ -31,6 +31,7 @@
     depends_modellist,
     depends_registry,
     depends_upload,
+    depends_upload_enabled,
     get_app,
     get_appconfig,
     get_dependencies,
@@ -47,6 +48,7 @@
     TaskStatusModel,
     TransformationStatus,
     UploadDataResponse,
+    UploadNotEnabledError,
     task_to_transformation_map,
 )
 
@@ -100,8 +102,11 @@ async def root():
 @app.put("/data/cache", operation_id="createDataset")
 async def upload_data(
     object_key: UUID = Depends(depends_upload),
+    upload_enabled: bool = Depends(depends_upload_enabled),
 ) -> UploadDataResponse:
     """Upload data from internal cache"""
+    if not upload_enabled:
+        raise UploadNotEnabledError("Direct upload to cache is not enabled")
     return UploadDataResponse(id=object_key, last_modified=str(datetime.now()))
 
 
@@ -321,6 +326,17 @@ async def download_error_handler(request, exc):  # pylint: disable=unused-argume
     return JSONResponse(status_code=422, content="Error while fetching the resource")
 
 
+@app.exception_handler(UploadNotEnabledError)
+async def upload_error_handler(request, exc):  # pylint: disable=unused-argument
+    """Return response based on the MinioDownloadError"""
+    # Raise an HTTPException with a 422 status code and the error messages
+    return JSONResponse(
+        status_code=403,
+        content="""Direct upload to cache is not enabled.
+    Please contact an administrator.""",
+    )
+
+
 # @app.exception_handler(MinioConnectionError)
 # async def connection_error_handler(request, exc):  # pylint: disable=unused-argument
 #     """Return response based on the MinioDownloadError"""

osp/app/models.py

@@ -172,3 +172,7 @@ class InfoType(str, Enum):
 
     SCHEMA = "Schema"
     EXAMPLE = "Example"
+
+
+class UploadNotEnabledError(Exception):
+    """Upload not permitted since not enabled by admin."""

osp/settings/__init__.py

@@ -57,6 +57,12 @@ class AppConfig(RedisSettings):
         None, description="Resolvable hostname to the outside world."
     )
 
+    enable_upload: Optional[bool] = Field(
+        False,
+        description="""Whether direct data upload into
+        the cache should be enabled or not""",
+    )
+
     class Config:
         """Pydantic config for FastAPI-celery settings"""