Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix most cell outputs on the Quantum ESPRESSO wrapper tutorial #72

Closed
wants to merge 3 commits into from

Conversation

urbanmatthias
Copy link
Member

No description provided.

mathias-driesse and others added 3 commits August 10, 2020 12:43
* Update to v3.3.9

* updated the ontology documentation

* updated entity names and imports in markdown files

* updated notebooks

* update ontology2dot image

* `nbconvert --execute` requires the jupyter_client package: `pip install jupyter_client` Fixes #16

* updated nbsphinx_kernel_name in conf.py
* updated requirements

* Add JSON schema of serialized CUDS objects to docs Fixes #21

* added missing files

* Document yaml2camelcase Fixes #25

* Updated link to RTD

* renamed openapi folder

* added CI action

* updated CI file

* added wheel to requirements

* moved wheel to CI file

* added rtd theme to req

* added pandoc

* added latexmk

* split dependencies

* split dependencies

* conf file for create-issue-branch

* updated paths

* added pico conflict notes

* added notes, hints and warning boxes

* Added wrapper_dev tutorial

* Reorganised the docs

* Reorganised wrapper section

* Update pico and installation (#34)

* updated pico uninstall all

* Updated installation notes

* Added badges (#40)

* osp-core is open source

* standalone section for installation

* added conda to installation

* removed references to pickle

* Fixed typo in tutorial

* Added note on tutorial download

* updated cuba.class references

* updated namespace import

* updated CI

* updated graph

* add vector notes, rename ontologies included

* notes on json serialisation

* added contact section, minor fixes

Co-authored-by: Matthias Urban <matthias.urban@iwm.fraunhofer.de>
Co-authored-by: Matthias Urban <42069939+urbanmatthias@users.noreply.github.com>
@kysrpex kysrpex changed the title Add imprint Fix the cell output on the Quantum ESPRESSO wrapper tutorial Apr 12, 2021
@yoavnash
Copy link
Member

Does it close #66?

@kysrpex
Copy link
Contributor

kysrpex commented Apr 12, 2021

Does it close #66?

Unfortunately not, I just noticed that it fixes most cell outputs but not all cell outputs.

@kysrpex kysrpex changed the title Fix the cell output on the Quantum ESPRESSO wrapper tutorial Fix most cell outputs on the Quantum ESPRESSO wrapper tutorial Apr 12, 2021
@kysrpex
Copy link
Contributor

kysrpex commented Apr 12, 2021

I tried to solve the conflict squashing instead of creating the merge commit but I did it wrong, so now the pull request's code was merged in commit 3735982 to dev, but GitHub did not detect this. Therefore I am closing the pull request.

@kysrpex kysrpex closed this Apr 12, 2021
@kysrpex kysrpex deleted the add-imprint branch April 12, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants