Use $DATASETTE_INTERNAL in absence of --internal #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efined, then use that
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2174 +/- ##
=======================================
Coverage 92.68% 92.68%
=======================================
Files 40 40
Lines 6012 6017 +5
=======================================
+ Hits 5572 5577 +5
Misses 440 440
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
|
We can use this here: https://click.palletsprojects.com/en/8.1.x/options/#values-from-environment-variables @click.option(..., envvar="DATASETTE_INTERNAL") |
|
|
asg017
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#refs 2157, specifically this comment
Passing in
--internal my_internal.dbover and over again can get repetitive.This PR adds a new configurable env variable
DATASETTE_INTERNAL_DB_PATH. If it's defined, then it takes place as the path to the internal database. Users can still overwrite this behavior by passing in their own--internal internal.dbflag.In draft mode for now, needs tests and documentation.
Side note: Maybe we can have a sections in the docs that lists all the "configuration environment variables" that Datasette respects? I did a quick grep and found:
DATASETTE_LOAD_PLUGINSDATASETTE_SECRETS📚 Documentation preview 📚: https://datasette--2174.org.readthedocs.build/en/2174/