Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15 new icons sets for HomePoint #143

Open
wants to merge 59 commits into
base: master
Choose a base branch
from
Open

15 new icons sets for HomePoint #143

wants to merge 59 commits into from

Conversation

htvekov
Copy link

@htvekov htvekov commented Jan 19, 2021

Thirteen additional icons added.
Format: 50 x 50 pixels JPEG
Colours: 'Standard' white, black and HEX:CDB949 for 'active' icon
Alternative to original and now closed PR #136

15 new icons sets for HomePoint.
Format: 50 x 50 pixels JPEG
Colours: 'Standard' white, black and HEX:CDB949 for 'active' icon

Only PD/CC types included.
CC icons listed needs to be credited in HomePoint documentation if used (I guess ?)

Origin of icons below:

Free icons/public domain:
ceilinglamp: https://icon-library.com/icon/furniture-icon-png-19.html
shower: https://www.flaticon.com/free-icon/shower_2425854
hallway: https://icon-library.com/icon/hallway-icon-18.html
desklamp: https://icon-icons.com/icon/desk-lamp/136702
oven: https://icon-library.com/icon/kitchen-icon-png-9.html
utilityroom: https://thenounproject.com/term/washing-machine/118/
term=spotlight&page=1&position=31&page=1&position=31&related_id=3309161&origin=tag

CC (Creative Commons):
carport: https://thenounproject.com/term/carport/2603315/
patio: https://thenounproject.com/term/patio/489162/
greenhouse: https://www.pngrepo.com/svg/159375/greenhouse
table lamp: https://www.svgrepo.com/svg/96335/lamp
officechair: https://www.pngrepo.com/svg/80220/chair
bathroom: https://thenounproject.com/term/toilet/1386555/
floorlamp: https://thenounproject.com/term/floor-lamp/132467/
spotlight: https://www.flaticon.com/free-icon/spotlight_3309161?term=spotlight&page=1&position=31&page=1&position=31&related_id=3309161&origin=tag
officetable: https://pngtree.com/freepng/vector-study-table-vector-icon_4103085.html
@sieren
Copy link
Owner

sieren commented Jan 19, 2021

There's a lot of icons in there that need attribution. I've picked one randomly at https://www.flaticon.com/free-icon/shower_2425854 and it needs attribution, though you said it's public domain.
What's more so problematic is the mixing of licenses since HomePoint is under MIT License.

There is too little information about icon-library.com, in fact their Terms of Use don't even exist (neither do their Privacy Policy), so I'm very sceptical about the source there.

Is there any way you can self-host these somewhere? I'm happy to add a link to additional icons in the Wiki, as users can also just download these and upload them manually through the web interface.

I appreciate all your work though and I hope you understand the reasons why I can't merge this right away.

@htvekov
Copy link
Author

htvekov commented Jan 20, 2021

No worries, Matt 😎

I could have done my homework properly and payed more attention to the license part.
Quite a few ad sponsored,crap icon sites out there 😒🙄 Read up a bit on things now.

Anyway, I would still suggest that you get as many icons as possible in the 'ready for use' binaries.
Simply because it's much easier for the end user. And also because the SPIFFS filesystem issue could cause some serious problems, if users were to upload some 30 files for 15 additional icons sets. I have to reflash on a regular basis, with all my testing these days.

I've (once again and now more thoroughly) revised the icons and split them in two groups:

  • One group with the PD and CC0 icons - All could be locked and loaded into the code without issues ! 🚀🚀
  • Second group with the CC BY icons (which I'll host somewhere. GitHub repo or my Dropbox)

Let me know if you agree to continue with this, Matt 🙂

Revised icon list below:

Public Domain:
utilityroom: https://thenounproject.com/term/washing-machine/118/

CC0 (No attribution needed)
Equals to PD under Creative Commons license. Icons can be used 'as is' or altered under any license.
Same CC license as some of your existing icons share 😉
greenhouse: https://www.pngrepo.com/svg/159375/greenhouse
tablelamp: https://www.svgrepo.com/svg/96335/lamp
officechair: https://www.pngrepo.com/svg/80220/chair
desklamp: https://www.svgrepo.com/svg/140489/desk-lamp (NEW)
studylamp: https://www.pngrepo.com/svg/145887/studying-lamp (NEW)
hallway: https://www.pngrepo.com/svg/132070/coat-stand-livingroom-furniture (NEW)
shower1: https://www.svgrepo.com/svg/48096/shower (NEW)
shower2: https://www.svgrepo.com/svg/128336/shower-head (NEW)
oven: https://www.svgrepo.com/svg/219106/oven (NEW)
bathroom: https://www.svgrepo.com/svg/3895/toilet (NEW)

CC BY (Needs attribution) - Hosted externally. I'll provide link
carport: https://thenounproject.com/term/carport/2603315/
patio: https://thenounproject.com/term/patio/489162/
bathroom: https://thenounproject.com/term/toilet/1386555/
floorlamp: https://thenounproject.com/term/floor-lamp/132467/
ceilinglight: https://thenounproject.com/term/ceiling-light/1942774/ (NEW)
office: https://thenounproject.com/search/?q=studying+table&i=3234597 (NEW)

Ciao ! 🙋‍♂️

@htvekov
Copy link
Author

htvekov commented Jan 20, 2021

Hi' @sieren

Complete set of icons now uploaded to Dropbox.
Public link: https://www.dropbox.com/sh/g7lxlquzejkrckc/AAC2YCSHoYukfV4v_f12Uegda?dl=0

8 CC BY - and 15 PD/CC0 icons in total.

Ciao !

@sieren
Copy link
Owner

sieren commented Jan 20, 2021

Awesome! Thanks a lot for your work! I'm a bit overwhelmed with my regular job this week so it might take some time till I've reviewed these. I'll make sure we'll get these in the repo though :)
I might have to rebase this and clean up the commit history a little hehe

@htvekov
Copy link
Author

htvekov commented Jan 20, 2021

You're very welcome, Matt 👍
And - no rush... 😉

Just glad I could contribute with something (hopefully) usefull.
Sorry about the mess I've made with the commits 😫 I really have to learn how to navigate and use Github properly.

@htvekov
Copy link
Author

htvekov commented Jan 20, 2021

And SPIFFS gave up on me after some 20 additional file uploads or so... 😖
Reflash ⚡⚡⚡

@ghosty-be
Copy link
Contributor

ghosty-be commented Feb 25, 2021

just wondering about icons...
I downloaded a flame icon in jpg format 24x24 (as that was easy to find) since I monitor gas usage in my home...
it's default black on white, which looks a bit strange on black background that shows as white square with black flame...
So opened it in gimp, inverted the color (so it's white flame on black background...)
tried all kinds of export to jpg settings,like saving or not saving the color profile or icon etc but to no avail...
even tried to set mode to grayscale but it just won't show in my screen,
when I overwrite the image again with the black on white original it works fine...
also wondering why the choice of jpg while gif / png have transparent background and are much more freely scalable and smaller I'd guess? :)

@htvekov
Copy link
Author

htvekov commented Mar 4, 2021

Hi' @ghosty-be

Did you check the readme.txt at my dropbox link.
Here colour code for the 'golden' colour is mentioned.
All the icons I've in that link we're done using Paint 3D - nothing fancy really.
Just filled the icons with new colours and basically not much else than converting to 50x50 pixels afterwards.
Yes, gif/png would have been easier, but now jpg was used so I just went with the flow... 😉

Ciao !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants