Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-31047 - Improve payment handlers #3708

Draft
wants to merge 10 commits into
base: trunk
Choose a base branch
from

Conversation

mstegmeyer
Copy link
Contributor

1. Why is this change necessary?

2. What does this change do, exactly?

3. Describe each step to reproduce the issue or behaviour.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@mstegmeyer mstegmeyer marked this pull request as draft May 13, 2024 08:26
Copy link

github-actions bot commented May 13, 2024

Warnings
⚠️ Please be kind and add unit tests for your new code in these files:
src/Core/Checkout/Payment/Cart/PaymentHandler/PaymentHandlerType.php
If you are sure everything is fine with your changes, you can resolve this warning.
You can run `composer make:coverage` to generate dummy unit tests for files that are not covered

@mstegmeyer mstegmeyer self-assigned this May 13, 2024
@CLAassistant
Copy link

CLAassistant commented May 13, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ lernhart
❌ mstegmeyer
You have signed the CLA already but the status is still pending? Let us recheck it.

@mstegmeyer mstegmeyer force-pushed the next-31047/improve-payment-handlers branch 6 times, most recently from 088322b to 8b73ed4 Compare May 14, 2024 16:05
@mstegmeyer mstegmeyer force-pushed the next-31047/improve-payment-handlers branch from 8b73ed4 to da358c3 Compare June 6, 2024 21:12
@mstegmeyer mstegmeyer force-pushed the next-31047/improve-payment-handlers branch from da358c3 to 6b0e5d0 Compare June 6, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants