fix: Order of the ZIP code and city field

[aragon999]

1. Why is this change necessary?

https://forum.shopware.com/t/im-registrierungsformular-steht-ort-vor-plz/103671/4
46ee060#diff-bec516e908622f4a6c0862196e64e5a62997373658b915cd3153f73fd04253ff

2. What does this change do, exactly?

Interchange the order and for good measure, also add blocks.

3. Describe each step to reproduce the issue or behaviour.

-

4. Please link to the relevant issues (if any).

-

5. Checklist

• I have rebased my changes to remove merge conflicts
• I have written tests and verified that they fail without my change
• I have created a changelog file with all necessary information about my changes
• I have written or adjusted the documentation according to my changes
• This change has comments for package types, values, functions, and non-obvious lines of code
• I have read the contribution requirements and fulfil them.

[aragon999]

Maybe the "fix" is not sufficient, as it has been pointed out, that for some countries it might be needed that the order is reversed. Not sure if the configuration option should be added again (and if so, at which place?).

[mstegmeyer]

Just swapping the fields is not the solution, I believe. We should either bring back the option that was removed due to the new address formatting or apply the new address formatting to the registration form as well (difficult, due to the country selection being at the end).

[mstegmeyer]

Hey @aragon999,

first of all, nice to meet you yesterday 💙
We have had some internal discussion today regarding this. We are not happy with this quick fix of just swapping, because it is just different in different regions (e.g. the US usually have "city - state - zip"). We can't really make everyone happy.
The original thought of our POs was to port the address formatting that already exists for e.g. documents also into the registration form, but we are not there yet and won't be for 6.6 for sure.
If you want to do this, you could bring back the toggle that existed in 6.5 (and was kind of wrongly deprecated and removed). Please adjust the snippet of the setting in the Administration so that it just refers to the forms, not the text form. Also, we would love it if you also introduced the blocks, another oversight on our side.

Please give us a quick ping if you plan to do this or we can close this PR.

Kind regards from Schöppingen,
another Max 😉

[mstegmeyer]

I will close this for now, feel free to open a new PR with the old toggle.

[aragon999]

Hey @mstegmeyer,

yes, very nice to meet you as well :-)

Sorry it was quite a busy time and week, so I missed to answer here 🙈 But I will create a new PR where I add the config again. But probably only next week.

Best, Max :-)