Add Wii port #73
Add Wii port #73
Conversation
|
Hi Wouter, I went on and created the manifest and icon myself. Please let me know, if they are fine. I also added a script to make a release. For the time being, I'll put the release on my own fork and submit the app to the Open Shop Channel, but as soon as you decide to support the Wii port in this repository, I'll submit a change so that this will become the reference repo for any future release. |
|
This is so cool, thanks for doing this! I'll take a look at it. |
There was a problem hiding this comment.
This is a really good start, I really like the idea of seeing OceanPop on more platforms. I had a couple of comments, which I think would be doable to resolve before merging, but let me know if you have the time to address them. The current work is pretty good and I'm surprised you only needed 1 code change.
One thing I'd like to have added if it is not too much work, would be to add an automated build for the Wii to .github/workflows/build.yml. Would that be doable?
platform/wii/make_release.sh
Outdated
There was a problem hiding this comment.
Would it be possible to build the package using CMake instead?
I would suggest using the add_custom_command function in CMake to add post build commands for running the zip command the and the file command for copying.
For the config file, I would add version as an option (using the option function) and use the configure_file function to do the substitution.
There was a problem hiding this comment.
Mmm... While I agree that it would be cleaner, it's also a bit more inconvenient, because you need to set the version number at the time when you run cmake. I can try to do that, but it will take me some more time.
mardy
force-pushed
the
wii-port
branch
2 times, most recently
from
d8073d6
to
59ca6a1
Compare
Done (you can see a run in my fork). I'm not familiar with github actions, though, so let me know if it could be improved. And I have no idea where the artifacts have been uploaded to, so I can't even verify that they are correct :-D |
.github/workflows/build.yml
Outdated
| name: oceanpop-wii | ||
| path: | | ||
| oceanpop/oceanpop*.zip | ||
|
|
||
| Release: | ||
| needs: [Linux, Windows, PSP, Vita] |
There was a problem hiding this comment.
Can you add Wii here? This looks good otherwise. It's working well too.
Below here on line 161 you'll also need to add wii
|
Sorry for getting back to you so late. I had not seen you made the requested changes. Thanks for that! |
Thanks Wouter for this nice game, it's written very well and it was a pleasure to port it :-)
Please note that in order for the port to be complete, we need a 128x48 icon file (png) and an XML manifest. If you can provide them to me (at least the icon and the description text for the manifest), then I can add them to this PR.
We should submit the game to the Open Shop Channel, then.