This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
default typeName is null since _type is removed in ESv7 and unsupported in ESv8+ #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am also having issues with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in ESv8+
What issue does this PR address?
#375
Does this PR introduce a breaking change?
Technically, yes, but since _type is unsupported in ESv8+, then NO. You can't break what is already broken.
Please check if the PR fulfills these requirements
Other information:
current default is a blocker when trying to configure ES sink from json/yaml, since typename=null or typename="" is just ignored and default typename="_doc" remains in place