Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

fix: correctly reading bufferRetainedInvalidPayloads from appsettings #398

Conversation

DinoSourcesRex
Copy link

What issue does this PR address?
bufferRetainedInvalidPayloadsLimitBytes is not read from appsettings

Does this PR introduce a breaking change?
No, I hope not

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)

Other information:
I have not created an issue for this as it is only a small change. If you'd like me to do so before the merge I can do it.

I discovered this when trying to figure out why invalid-guid files were not being removed from my log folder.

@DinoSourcesRex
Copy link
Author

Looks to me like the myget index, dotnet-core in the nuget.config is not pointing to an actual resource anymore. Not entirely sure, some resources online point to adding a proxy into the nuget.config package.

If no one knows what is going on I can try to fix this at some point, not sure if I have the appropriate permissions or not though.

@DinoSourcesRex
Copy link
Author

Well. According to this link dotnet.myget.org was retired (answer from a microsoft employee).

@mivano
Copy link
Contributor

mivano commented Oct 11, 2021 via email

@DinoSourcesRex
Copy link
Author

@mivano just FYI looks like I duplicated this PR - that's what I get for not checking existing PRs.

@mivano mivano closed this Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants