Some improvenents/cleanups in the GEOFON module; added a docstring #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yetinam
reviewed
Sep 27, 2023
| @@ -23,8 +24,65 @@ class GEOFON(BenchmarkDataset): | |||
| GEOFON dataset consisting of both regional and teleseismic picks. Mostly contains P arrivals, | |||
| but a few S arrivals are annotated as well. Contains data from 2010-2013. The dataset will be | |||
| downloaded from the SeisBench repository on first usage. | |||
|
|
|||
There was a problem hiding this comment.
Thanks for adding the extensive docstring. I think it would be good to put a subheading in between to make clear these details refer to the source data for converting the dataset from scratch.
yetinam
reviewed
Sep 27, 2023
| """ | ||
|
|
||
| start_train = "2010-01-01" |
There was a problem hiding this comment.
Maybe we should also add an end_data field or similar to indicate data until which data was used in the conversion.
yetinam
reviewed
Sep 27, 2023
yetinam
reviewed
Sep 27, 2023
yetinam
reviewed
Sep 27, 2023
yetinam
reviewed
Sep 27, 2023
yetinam
reviewed
Sep 27, 2023
yetinam
added
enhancement
|
PR is still a draft, do not merge yet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.