This repository has been archived by the owner on Sep 7, 2023. It is now read-only.
added icons to search results #2951
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just leaving a comment here to say that I think favicons should go through the image proxy. The PR looks good though. |
mrpaulblack
added a commit
to mrpaulblack/searxng
that referenced
this pull request
Oct 26, 2021
* basically from: searx/searx#2951 * favicons are going through image proxy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds icons next to search result urls. changes are only made in macros.html. websitename.com/favicon.ico is assumed to have the icon image. dynamically get the images for each website and minor css to adjust with the inline link.
Why is this change important?
This was stated as a performance enhancement. [Feature request] Show icon of domain URLs #1690
How to test this PR locally?
all normal testing as stated in the docs.
Author's checklist
I am a first time open source contributor. Any reviews or mistakes are welcome
Related issues
[Feature request] Show icon of domain URLs #1690