New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary `pub` #497

Open

Ten0 wants to merge 1 commit into scylladb:main from Ten0:remove_unnecessary_pub

Contributor

Ten0 commented Aug 10, 2022

(non backwards-compatible)

Alternately we could make this return an explicit type so that it's expressable, but I doubt that would actually be necessary for anyone.

scylla-rust-driver/scylla-cql/src/frame/value.rs

Line 189 in db8d528

pub fn iter(&self) -> impl Iterator<Item = Option<&[u8]>> {


          Remove unnecessary pub

8bb980f

(non backwards-compatible)

Alternately we could make this return an explicit type so that it's
expressable, but I doubt that would actually be necessary for anyone.
https://github.com/scylladb/scylla-rust-driver/blob/db8d52893bdef56977872a09f51fda2fa423168f/scylla-cql/src/frame/value.rs#L189

wprzytula mentioned this pull request

Decrease excessive visibility from pub throughout the crate #660

Open

wprzytula added API-breaking API-stability labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment