Prepared statements #428
Open
Prepared statements #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ponewor
force-pushed
the
prepared_statements
branch
from
29110a3
to
242c825
Compare
It's particularly useful in IntoUserType and FromUserType macros to be able to express that a column has CQL Time type. For that we need a wrapper, and a perfect candidate for that is scylla::frame::value::Time, which is already a thin wrapper over chrono::Duration. This patch simply implements FromCqlVal for this struct, which will allow using it for serialization and deserialization. Fixes scylladb#421
…fo method's consistency argument from Option<Consistency> to Consistency to make use of Query::set_consistency method and simplify the code
Ponewor
force-pushed
the
prepared_statements
branch
from
242c825
to
95d1d82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Attempts to partially solve: #417
This PR emphasises some points I have made there.
Fixes:annotations to PR description.