Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect ForeignKey on_delete: SET_NULL, DO_NOTHING #86

Merged
merged 2 commits into from
May 30, 2022
Merged

Respect ForeignKey on_delete: SET_NULL, DO_NOTHING #86

merged 2 commits into from
May 30, 2022

Conversation

PratikBodawala
Copy link
Contributor

Pratik Bodawala added 2 commits April 2, 2022 14:12
🔧 (admin.W411) 'django.template.context_processors.request' warning f…
7c31283 
…ixed
✨ respect on_delete values: SET_NULL, DO_NOTHING
ec652d1 
✨ delete operation in atomic transaction, in order to prevent dangling state
✅ updated testcases
@PratikBodawala PratikBodawala marked this pull request as draft April 10, 2022 05:36
@PratikBodawala PratikBodawala marked this pull request as ready for review April 10, 2022 05:36
@PratikBodawala
Copy link
Contributor Author

@scoursen, Could you review my PR?

This was referenced May 30, 2022
Closed
Open
@scoursen scoursen merged commit 6615c25 into scoursen:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevecoursen stevecoursen stevecoursen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't work with SET_NULL
3 participants
@PratikBodawala @stevecoursen @scoursen