Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: use PyTorch 2.3 in CI, fix CuPy failures, more type annotations for _array_api.py #20744

Merged
merged 4 commits into from
May 19, 2024
Merged

MAINT: use PyTorch 2.3 in CI, fix CuPy failures, more type annotations for _array_api.py #20744

merged 4 commits into from
May 19, 2024

Conversation

rgommers
Copy link
Member

No description provided.

@rgommers rgommers added maintenance Items related to regular maintenance tasks CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure static typing Items related to static typing array types Items related to array API support and input array validation (see gh-18286) labels May 18, 2024
@rgommers rgommers requested review from mdhaber and lucascolley and removed request for andyfaff and larsoner May 18, 2024 21:24
lucascolley
lucascolley approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@lucascolley lucascolley added this to the 1.14.0 milestone May 18, 2024
@rgommers rgommers changed the title MAINT: use PyTorch 2.3 in CI, fix CuPy failurs, more type annotations for _array_api.py MAINT: use PyTorch 2.3 in CI, fix CuPy failures, more type annotations for _array_api.py May 18, 2024
mdhaber
mdhaber approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@mdhaber mdhaber left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stats and _chandrupatla things look fine. Looks like MyPy is still complaining about milp. You're getting something different locally?

mdhaber
mdhaber reviewed May 18, 2024
View reviewed changes
scipy/optimize/_milp.py Outdated Show resolved Hide resolved
@rgommers
CI: upgrade PyTorch version in array API job from 2.0 to 2.3
64aebfd
@rgommers
TYP: extend type annotations in _lib/_array_api.py
3b36af3 
Also resolve a couple of errors visible with MyPy locally.

[skip circle] [skip cirrus]
@rgommers
TST: fix test failures on GPU for stats.jarque_bera
c97172b 
It converts to/from numpy arrays internally, so is cpu-only.
@rgommers
TST: optimize: fix test tolerance of chandrupatla for CuPy
217d66e 
Some `test_vectorization` tolerances were in the 1e-10 range, so
similar to those for PyTorch.
@rgommers
Copy link
Member Author

CircleCI failure is a network issue. Mypy is happy now. I'll put this in - thanks for the reviews @lucascolley and @mdhaber

@rgommers rgommers merged commit dc2de6d into scipy:main May 19, 2024
26 of 27 checks passed
@rgommers rgommers deleted the array-types-maint branch May 19, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdhaber mdhaber mdhaber approved these changes

@lucascolley lucascolley lucascolley approved these changes

Assignees
No one assigned
Labels
array types Items related to array API support and input array validation (see gh-18286) CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure maintenance Items related to regular maintenance tasks scipy._lib static typing Items related to static typing
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rgommers @mdhaber @lucascolley