ENH: stats.variation: add array-API support #20647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
scipy.stats
CI
j-bowhay
commented
May 5, 2024
j-bowhay
commented
May 5, 2024
mdhaber
reviewed
May 5, 2024
68 tasks
mdhaber
reviewed
May 5, 2024
mdhaber
reviewed
May 5, 2024
| # torch | ||
| sup.filter(UserWarning, "std*") | ||
| y = variation(x) | ||
| xp_assert_equal(y, xp.asarray(xp.nan, dtype=x.dtype)) |
There was a problem hiding this comment.
Not a big deal, but you could change np.zeros(5) to [0.]*5 to avoid the explicit dtype, if we prefer testing the default type. Then again, one could argue that now this tests both the default type and float64 (if they are different), and coverage is a good thing. Either way; just an observation.
There was a problem hiding this comment.
I meant that since you changed np.zeros to [0.]*, you should be able to do:
Suggested change
| xp_assert_equal(y, xp.asarray(xp.nan, dtype=x.dtype)) | |
| xp_assert_equal(y, xp.asarray(xp.nan)) |
mdhaber
reviewed
May 5, 2024
mdhaber
reviewed
May 5, 2024
mdhaber
approved these changes
May 5, 2024
mdhaber
reviewed
May 5, 2024
scipy/stats/_variation.py
Outdated
| result[i] = np.copysign(result[i], mean_a[i]) | ||
| return result[()] | ||
| std_a = xp.std(a, axis=axis, correction=0) | ||
| result = xp.where(std_a > 0, xp.copysign(xp.asarray(xp.inf), mean_a), NaN) |
There was a problem hiding this comment.
Oops. Looks like we need an xp_copysign in the meantime (j-bowhay#4). I'd recommend installing array_api_strict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #20544