ENH: stats.rankdata: add array API support #20639
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
added
scipy.stats
enhancement
github-actions
bot
added
scipy._lib
CI
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Towards gh-20544
What does this implement/fix?
Adds array API support to
scipy.stats.rankdata.Additional information
No need to review this yet. While working on it, I found that it needs several things that aren't covered by
array_api_compatyet (e.g.repeat,moveaxis, NumPyasarraywithcopy=False), and it would also really benefit from the array API supportingtake_along_axis(data-apis/array-api#177) anddiff(data-apis/array-api#791). Also, withoutput(or preferablyput_along_axis), this needed a secondargsort. As-is, this would introduce a substantial performance regression.