-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: backports/prep for 1.13.1 #20632
Changes from all commits
42de094
ba975c4
e5666b6
eb8e3a9
1541f68
85c9e29
3687a97
3c3ac73
5006ef1
15cf993
3ec0606
768f46b
178a125
a2373cb
c7b7322
57e3699
4b6d2e1
a9afa6f
adaa430
de2a454
f2d4873
b481e5d
74e9a4a
a536ab1
ee6203d
d08c8d8
198a73b
4fa2e23
67d4252
5582720
5c770e8
7db39e8
cec68d7
f1575a8
870e5b4
ce91a92
8b9a6d6
023b0fb
aa32933
e7abaf1
95c50a4
c9d8613
506cbeb
11e99ba
1a00d48
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ cirrus_wheels_linux_aarch64_task: | |
platform: linux | ||
cpu: 2 | ||
memory: 4G | ||
timeout_in: 72m | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I tried restarting twice; this is probably cheaper than needing to hit restart several times during the rel process. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1 that makes sense to me, it was always close to the limit. |
||
matrix: | ||
# build in a matrix because building and testing all four wheels in a | ||
# single task takes longer than 60 mins (the default time limit for a | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rgommers @h-vetinari This PR is taking shape I think--the full CI matrix (including wheels) is finally passing. The changes inline above are probably the most annoying/controversial ones I had to make manually (they are probably a superset of what is really needed to get Mac ARM wheels passing).
Any remaining objections/concerns for
1.13.1
release? We're at parity with the current list of merged backport-labeled PRs (30 in total now). I have two checklist items left above, but they are basically just updating the relnotes and reading the diff carefully before proceeding.@mdhaber @dschult @perimosocordiae any more backports that are important for
stats
orsparse
for1.13.1
?I think if folks are happy I'd try to get
1.13.1
out before branching1.14.0
, with a modest delay likely for the latter, but hopefully not too substantial (I'm blocking off time for release notes work tomorrow).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None that I can think of. This is already quite large, so +1 for shipping it soon.
The changes for macOS gfortran should be okay - whatever works there I think is fine in a maintenance branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get to see this earlier, but I think this has all the backports I had in mind.