Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: spatial.cKDTree: do not slide the median #20606

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

BUG: spatial.cKDTree: do not slide the median #20606

wants to merge 10 commits into from

Commits on Apr 29, 2024

  1. fix sliding midpoint problem in build.cxx 

    Never slide the pivot when using median as pivot. Only slide the pivot when pivot is the midpoint. That’s what sliding midpoint means.
    @sturlamolden
    sturlamolden committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6ea6a4f View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. full partial sort following calculation of median

    @sturlamolden
    sturlamolden committed May 8, 2024
    Configuration menu
    Copy the full SHA
    b16f6ed View commit details
    Browse the repository at this point in the history

  2. add test for scipygh-20605

    @sturlamolden
    sturlamolden committed May 8, 2024
    Configuration menu
    Copy the full SHA
    ea4f65e View commit details
    Browse the repository at this point in the history

  3. fix Lint error

    @sturlamolden
    sturlamolden committed May 8, 2024
    Configuration menu
    Copy the full SHA
    c0f38eb View commit details
    Browse the repository at this point in the history

  4. temporarily disable test

    @sturlamolden
    sturlamolden committed May 8, 2024
    Configuration menu
    Copy the full SHA
    6ff4cc7 View commit details
    Browse the repository at this point in the history

  5. remove bounds meddling hack, logic error

    @sturlamolden
    sturlamolden committed May 8, 2024
    Configuration menu
    Copy the full SHA
    5b30afe View commit details
    Browse the repository at this point in the history

  6. use taboo list for ill-behaved dimensions

    @sturlamolden
    sturlamolden committed May 8, 2024
    Configuration menu
    Copy the full SHA
    7bc7253 View commit details
    Browse the repository at this point in the history

  7. fix missing variable declaration

    @sturlamolden
    sturlamolden committed May 8, 2024
    Configuration menu
    Copy the full SHA
    b2d2ef7 View commit details
    Browse the repository at this point in the history

  8. turn test for scipygh-20605 back on

    @sturlamolden
    sturlamolden committed May 8, 2024
    Configuration menu
    Copy the full SHA
    45dc44d View commit details
    Browse the repository at this point in the history

  9. Use sliding rule also on median pivot for stability 

    Median pivot (aka "standard split") results in stability issues when we have a lot of ties.
    @sturlamolden
    sturlamolden committed May 8, 2024
    Configuration menu
    Copy the full SHA
    2304fe7 View commit details
    Browse the repository at this point in the history