DEP: special: remove legacy kwarg from special.comb and switch to kwarg-only #20588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
scipy.special
deprecated
lucascolley
reviewed
Apr 26, 2024
There was a problem hiding this comment.
LGTM, thanks Jake! Just to check, @h-vetinari suggested deprecating non-integer input with exact=True in the linked issue - are we fine to raise an error here?
Yes, looking again I have been a bit over-eager here! |
|
Are you wanting to leave the new deprecation for a separate PR? |
Yes I think so let's leave the issue open with a note about what's left |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
#15765
towards #15722
What does this implement/fix?
scheduled for this release
Additional information