-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update openblas to 0.3.27 #20569
update openblas to 0.3.27 #20569
Conversation
Thanks Matti. CI is having a really bad day, unrelated to this PR. |
Thanks @mattip ! |
I'll tentatively add a backport label, though I did not reproduce locally with OpenBLAS swaps for whatever reason. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's give this a go. Thanks @mattip, all
Backporting seems like a good idea. Although the backport PR should run the wheel builds to make doubly sure everything is good there I think. |
Can I ask what's the expected timeline for this to be released ? I know scipy 1.13 happened off-schedule but when is 1.14 planned for ? |
https://discuss.scientific-python.org/t/proposed-release-schedule-for-scipy-1-14-0/ |
Strangely enough I've hit Reference-LAPACK/lapack#980 which is fixed in OpenBLAS 0.3.27 OpenMathLib/OpenBLAS#4484 We (are going to) use this in the linalg.interpolative rewrite (#20558) hence would be nice to have it indeed backported. |
Older OpenBLAS versions are going to be around for several more years (e.g. in Linux distros), so is it possible to find a workaround or a fallback? |
If we ship the wheels with new OpenBLAS 0.3.27 then the chances of hitting the bug (by old OpenBLAS version) really goes down by a lot. This is a corner case when some interim data is very small and hard to hit. I accidentally created it in my tests so it needs some effort to be hit by it. However, nice to have it fixed anyways. Anyways, long story short, it is a minute issue and can be fixed over time. Not many folks are using interpolative anyways. |
Reference issue
Closes #20531
What does this implement/fix?
Update to OepnBLAS 0.3.27 to fix a problem with SVD on arm64
Additional information