Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update openblas to 0.3.27 #20569

Merged
merged 1 commit into from
Apr 25, 2024
Merged

update openblas to 0.3.27 #20569

merged 1 commit into from
Apr 25, 2024

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Apr 24, 2024

Reference issue

Closes #20531

What does this implement/fix?

Update to OepnBLAS 0.3.27 to fix a problem with SVD on arm64

Additional information

@rgommers
Copy link
Member

Thanks Matti. CI is having a really bad day, unrelated to this PR.

@neutrinoceros
Copy link

Thanks @mattip !

@tylerjereddy tylerjereddy added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Apr 24, 2024
@tylerjereddy
Copy link
Contributor

I'll tentatively add a backport label, though I did not reproduce locally with OpenBLAS swaps for whatever reason.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's give this a go. Thanks @mattip, all

@rgommers rgommers merged commit 7e91642 into scipy:main Apr 25, 2024
32 checks passed
@rgommers
Copy link
Member

Backporting seems like a good idea. Although the backport PR should run the wheel builds to make doubly sure everything is good there I think.

@neutrinoceros
Copy link

Can I ask what's the expected timeline for this to be released ? I know scipy 1.13 happened off-schedule but when is 1.14 planned for ?

@lucascolley
Copy link
Member

when is 1.14 planned for ?

https://discuss.scientific-python.org/t/proposed-release-schedule-for-scipy-1-14-0/

@tylerjereddy tylerjereddy modified the milestones: 1.14.0, 1.13.1 May 2, 2024
@tylerjereddy tylerjereddy mentioned this pull request May 2, 2024
10 tasks
@ilayn
Copy link
Member

ilayn commented May 18, 2024

Strangely enough I've hit Reference-LAPACK/lapack#980 which is fixed in OpenBLAS 0.3.27 OpenMathLib/OpenBLAS#4484

We (are going to) use this in the linalg.interpolative rewrite (#20558) hence would be nice to have it indeed backported.

@rgommers
Copy link
Member

Older OpenBLAS versions are going to be around for several more years (e.g. in Linux distros), so is it possible to find a workaround or a fallback?

@ilayn
Copy link
Member

ilayn commented May 18, 2024

If we ship the wheels with new OpenBLAS 0.3.27 then the chances of hitting the bug (by old OpenBLAS version) really goes down by a lot. This is a corner case when some interim data is very small and hard to hit. I accidentally created it in my tests so it needs some effort to be hit by it. However, nice to have it fixed anyways. Anyways, long story short, it is a minute issue and can be fixed over time.

Not many folks are using interpolative anyways.

@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.linalg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: warning from optimize.least_squares for astropy with OpenBLAS 0.3.26-dev
6 participants