Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: integrate: switch simpson to kwarg-only, remove even kwarg #20554

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

j-bowhay
Copy link
Member

Reference issue

#15765
follow-up of #18209 & #18843

What does this implement/fix?

Scheduled for this release

Additional information

@j-bowhay j-bowhay requested a review from steppi as a code owner April 22, 2024 18:34
@github-actions github-actions bot added scipy.integrate deprecated Items related to behavior that has been deprecated labels Apr 22, 2024
Comment on lines -608 to -609
romberg : adaptive Romberg quadrature
quadrature : adaptive Gaussian quadrature
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are deprecated so we should remove the reference to them here

Comment on lines -616 to -617
ode : ODE integrators
odeint : ODE integrators
Copy link
Member Author

@j-bowhay j-bowhay Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ode solving really has very little to do with simpson's method...

@j-bowhay j-bowhay added this to the 1.14.0 milestone Apr 22, 2024
@j-bowhay j-bowhay mentioned this pull request Apr 22, 2024
29 tasks
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked the previous diffs. Will leave open for a few days

scipy/integrate/_quadrature.py Outdated Show resolved Hide resolved
[skip ci]

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
@lucascolley
Copy link
Member

thanks Jake

@lucascolley lucascolley merged commit 76f2d3c into scipy:main Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated Items related to behavior that has been deprecated scipy.integrate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants