Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: integrate: remove simps,trapz,cumtrapz #20278

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

j-bowhay
Copy link
Member

Reference issue

follow up to #18699

What does this implement/fix?

Deprecated for two releases so ready for the chopping block.

Additional information

@j-bowhay j-bowhay requested a review from steppi as a code owner March 18, 2024 20:14
@github-actions github-actions bot added scipy.integrate deprecated Items related to behavior that has been deprecated labels Mar 18, 2024
@j-bowhay j-bowhay mentioned this pull request Mar 18, 2024
29 tasks
Copy link
Contributor

@mdhaber mdhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass - unless we decided that these need to wait for 1.15 since 1.13 was not in the normal cadence? I looks like these weren't deprecated until 1.12, so this would only give 6 months. Some other features deprecated in 1.12 said they would be removed in 1.15 (Release Notes).

I am not finding any other appearances of these terms except for trapz, which is still allowed as an alias for the trapezoidal distribution and as a method option of quad_vec. (Those uses don't appear to have been deprecated.)

Aside - looks like we can now remove all those attributes from private namespaces that weren't marked with an underscore!

@j-bowhay
Copy link
Member Author

LGTM if tests pass - unless we decided that these need to wait for 1.15 since 1.13 was not in the normal cadence? I looks like these weren't deprecated until 1.12, so this would only give 6 months. Some other features deprecated in 1.12 said they would be removed in 1.15 (Release Notes).

Yes good spot it appear to have slipped off that list, I'll update this pr just to bump the message

@h-vetinari
Copy link
Member

When 1.13 was announced to be out-of-band, I did an analysis of the deprecations in 1.11/1.12 and whether to postpone them. In this case I don't think it's necessary to wait any longer, 1.14 should be fine IMO. The non-slur aliases have also existed for a long time already.

@h-vetinari
Copy link
Member

I am not finding any other appearances of these terms except for trapz, which is still allowed as an alias for the trapezoidal distribution and as a method option of quad_vec. (Those uses don't appear to have been deprecated.)

Hm yeah, we should deprecate those and remove them as well.

@mdhaber
Copy link
Contributor

mdhaber commented Mar 19, 2024

Thanks @h-vetinari.
@j-bowhay, with that in mind, shall I merge this?

@j-bowhay
Copy link
Member Author

Thanks for confirming @h-vetinari , happy to merge

@mdhaber mdhaber merged commit d891e40 into scipy:main Mar 19, 2024
30 checks passed
@mdhaber
Copy link
Contributor

mdhaber commented Mar 19, 2024

Thanks @j-bowhay @h-vetinari!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated Items related to behavior that has been deprecated scipy.integrate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants