-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: integrate: remove simps,trapz,cumtrapz #20278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if tests pass - unless we decided that these need to wait for 1.15 since 1.13 was not in the normal cadence? I looks like these weren't deprecated until 1.12, so this would only give 6 months. Some other features deprecated in 1.12 said they would be removed in 1.15 (Release Notes).
I am not finding any other appearances of these terms except for trapz
, which is still allowed as an alias for the trapezoidal distribution and as a method
option of quad_vec
. (Those uses don't appear to have been deprecated.)
Aside - looks like we can now remove all those attributes from private namespaces that weren't marked with an underscore!
Yes good spot it appear to have slipped off that list, I'll update this pr just to bump the message |
When 1.13 was announced to be out-of-band, I did an analysis of the deprecations in 1.11/1.12 and whether to postpone them. In this case I don't think it's necessary to wait any longer, 1.14 should be fine IMO. The non-slur aliases have also existed for a long time already. |
Hm yeah, we should deprecate those and remove them as well. |
Thanks @h-vetinari. |
Thanks for confirming @h-vetinari , happy to merge |
Thanks @j-bowhay @h-vetinari! |
Reference issue
follow up to #18699
What does this implement/fix?
Deprecated for two releases so ready for the chopping block.
Additional information