MAINT: fft: rename test_numpy.py to test_basic.py
#19000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: the text is added now. |
lucascolley
changed the title
test_numpy.py to test_basic.py [skip cirrus]
rgommers
changed the title
test_numpy.py to test_basic.py [skip cirrus]test_numpy.py to test_basic.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
N/A
What does this implement/fix?
test_numpy.pyis the file containing the tests for_basic.py.test_basic.pymore accurately describes what the tests do and matches the naming convention of the other test files.Additional information
This PR was motivated by work on adding support for the array API to
scipy.fft(see #18867). In that work, this file is modified to test_basic.pyfor any array API compatible backend, not justnumpy, so it would be a total misnomer there. This PR is separate because it is a general improvement regardless of the array API work, and will clean up the diff for that work when its PR is opened.