Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: mention that genlogistic is one of several types of generalized logistic distributions #18690

Merged
merged 3 commits into from
Jun 16, 2023

Conversation

dschmitz89
Copy link
Contributor

What does this implement/fix?

THere are several generalizations of the logistic distribution, genlogistic implements one of them. Acc. to Wikipedia, it is often to referred as type 1/skew logistic.. This is now mentioned in the notes section.

@dschmitz89 dschmitz89 added the Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org label Jun 16, 2023
@mdhaber
Copy link
Contributor

mdhaber commented Jun 16, 2023

Please post or email a screenshot of [1] so that I can verify. Also, please cite the source of "It is also referred to as the skew-logistic distribution", even if it's Wikipedia.

@dschmitz89
Copy link
Contributor Author

Please post or email a screenshot of [1] so that I can verify. Also, please cite the source of "It is also referred to as the skew-logistic distribution", even if it's Wikipedia.

Screenshot from Johnson:

image

Copy link
Contributor

@mdhaber mdhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks accurate. Hopefully docs build this time so we can see how they render.

@mdhaber
Copy link
Contributor

mdhaber commented Jun 16, 2023

Thanks @dschmitz89.

If you'd be willing to add a note that the loggamma distribution is actually the expgamma distribution, we could review and merge that quickly, too. I would also support adding the alias expgamma and deprecating loggamma.

I think loglaplace is also worth looking at. In quick tests, I was not able to confirm that either the logarithm or the exponential of a loglaplace random variable were distributed according to the laplace distribution.

@mdhaber mdhaber merged commit dbc2d3a into scipy:main Jun 16, 2023
1 check passed
@j-bowhay j-bowhay added this to the 1.12.0 milestone Jun 17, 2023
@dschmitz89
Copy link
Contributor Author

@mdhaber @j-bowhay : would it make sense to add the expgamma renaming to the depracation list #15765 ? I have never deprecated anything but could take a look.

@mdhaber
Copy link
Contributor

mdhaber commented Jun 19, 2023

It would need a note to the mailing list first, and I think that the PR with the deprecation would go in before adding to the tracker. The tracker reminds us to execute the removal of the deprecated behavior in two versions. (And a note in the existing documentation would also be ok with me, since it's less work.)

@dschmitz89 dschmitz89 deleted the genlogistic_doc branch July 18, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants