Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: sparse: Stop supporting multi-Ellipsis indexing #18541

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

perimosocordiae
Copy link
Member

Reference issue

This is the cleanup that we started warning about in gh-18540.

NOTE: We should not merge this until at least v1.13.0! I'll leave this in draft mode until then.

@perimosocordiae perimosocordiae added scipy.sparse maintenance Items related to regular maintenance tasks labels May 25, 2023
@j-bowhay j-bowhay mentioned this pull request May 26, 2023
29 tasks
@rgommers
Copy link
Member

NOTE: We should not merge this until at least v1.13.0! I'll leave this in draft mode until then.

Can you close this and reference it in the deprecation meta tracker issue (gh-15765) instead? Having a PR in the queue that's not mergeable for another year at least is a little annoying; it can be reopened when it's mergeable. We have folks that are good about going through the outstanding deprecations for every release.

@j-bowhay
Copy link
Member

I already have this in the tracker so will reopen it when we start development on 1.13

@j-bowhay j-bowhay closed this May 26, 2023
@perimosocordiae
Copy link
Member Author

Sounds good, thanks!

@h-vetinari h-vetinari reopened this Dec 12, 2023
@h-vetinari
Copy link
Member

1.12 has branched, so this is now fair game. :)

@j-bowhay
Copy link
Member

@perimosocordiae diff seems reasonable but just wanted to check in before merging that you were happy with everything since it has been 6+ months since opening

@perimosocordiae
Copy link
Member Author

Thanks, I just took another look and I'm happy with it.

@lucascolley lucascolley added this to the 1.13.0 milestone Dec 14, 2023
Copy link
Member

@j-bowhay j-bowhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert in this part of the codebase but diff looks reasonable and CI is happy, thanks @perimosocordiae

@j-bowhay j-bowhay merged commit d6af943 into scipy:main Dec 14, 2023
28 checks passed
@lucascolley lucascolley added the deprecated Items related to behavior that has been deprecated label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated Items related to behavior that has been deprecated maintenance Items related to regular maintenance tasks scipy.sparse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants