-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: sparse: Stop supporting multi-Ellipsis indexing #18541
Conversation
Can you close this and reference it in the deprecation meta tracker issue (gh-15765) instead? Having a PR in the queue that's not mergeable for another year at least is a little annoying; it can be reopened when it's mergeable. We have folks that are good about going through the outstanding deprecations for every release. |
I already have this in the tracker so will reopen it when we start development on 1.13 |
Sounds good, thanks! |
1.12 has branched, so this is now fair game. :) |
@perimosocordiae diff seems reasonable but just wanted to check in before merging that you were happy with everything since it has been 6+ months since opening |
Thanks, I just took another look and I'm happy with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an expert in this part of the codebase but diff looks reasonable and CI is happy, thanks @perimosocordiae
Reference issue
This is the cleanup that we started warning about in gh-18540.
NOTE: We should not merge this until at least v1.13.0! I'll leave this in draft mode until then.