Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: linalg: temporarily silence failure in test_solve_discrete_are #17273

Merged
merged 2 commits into from
Oct 23, 2022

Conversation

mdhaber
Copy link
Contributor

@mdhaber mdhaber commented Oct 21, 2022

Reference issue

gh-16926

What does this implement/fix?

gh-17057 xfailed a test failure similar to the one we're now seeing in linux_aarch64_test; this xfails the new one so that it is easier to see when there is a problem in a new PR.

Additional information

This should be reverted when gh-16926 gets resolved.
gh-17272 should address the issue in macos-arm64.

@mdhaber
Copy link
Contributor Author

mdhaber commented Oct 22, 2022

The goal of this PR was to silence the linux_aarch64_test failures, and that was successful. The issue with macos_arm64_test is addressed in #17272.

@ev-br ev-br merged commit 8894d2f into scipy:main Oct 23, 2022
@ev-br
Copy link
Member

ev-br commented Oct 23, 2022

Agreed, let's make CI green again. Thanks Matt

@andyfaff
Copy link
Contributor

I wonder whether it's worth us having a central location for us to record a list of the tests we need to restore because of things like this.

@ev-br
Copy link
Member

ev-br commented Oct 23, 2022

@andyfaff great idea indeed! Here's a start: #17278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.linalg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants