ENH/MAINT: qmc.LatinHypercube: deprecate centered with scramble
#17152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupui
added
scipy.stats
enhancement
j-bowhay
reviewed
Oct 5, 2022
mdhaber
reviewed
Oct 6, 2022
Co-authored-by: Matt Haberland <mhaberla@calpoly.edu>
tupui
commented
Oct 6, 2022
j-bowhay
approved these changes
Oct 6, 2022
|
Looks like it's time for a mailing list post. I'll merge a week after that. |
Co-authored-by: Matt Haberland <mhaberla@calpoly.edu>
|
Thanks Matt, just sent an email: https://mail.python.org/archives/list/scipy-dev@python.org/thread/PGUHB7L3ZKCLAG2PQ2MAOEFAOTJR36IK/ And thanks @j-bowhay for the review 👍 |
mdhaber
reviewed
Oct 6, 2022
Co-authored-by: Matt Haberland <mhaberla@calpoly.edu>
mdhaber
approved these changes
Oct 11, 2022
|
@h-vetinari another for #15765 |
|
@j-bowhay Thanks for the heads up. Hopefully I added it correctly. |
ev-br
pushed a commit
to ev-br/scipy
that referenced
this pull request
Oct 14, 2022
…scramble` (scipy#17152) * ENH/MAINT: `qmc.LatinHypercube`: deprecate `centered`; replace with `scramble`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can simplify the interface of
qmc.LatinHypercubeand make it consistent with other engines by removing thecenteredparameter and addingscramble. Not centering, the default, can be seen as scrambling. Which is the default for other engines. Hence there is an easy deprecation path with added consistency.In this PR:
centeredin favour ofscramble. Scrambling is about "adding some randomness" to a sample. As not scrambling might be interpreted as having a constant output, I added a note explaining that it's not the case.d<0inQMCEngine. We were only testing for integers