Reduce iteration over steps in _sk_visual_block_
#29022
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
N/A
What does this implement/fix? Explain your changes.
I was reading the code for
_sk_visual_block
, and I felt like it was unnecessary to getnames
andestimators
fromself.steps
separately (the first pass simply throws away names), so I figured I'd try some drive-by refactoring.Any other comments?
I know the "optimization" is very minimal, but I think it could also be viewed as cleaner (than discarding
names
in_
the first time around).