Add meeting notes from 2024-04-23 #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkcor
reviewed
Apr 24, 2024
| - What's the scope of the deprecation? | ||
| - Parameter `plugin` is used in old API and `imageio`, so pass-through would compete... | ||
| - Marianne: Not keeping `imread`, `imsave` around is actually clearer from an educational perspective -> `imageio` for IO, skimage for processing once we have an array | ||
| - Stéfan: imageio is not returning a "proper" array, would be good to keep a wrapper around that returns a pure NumPy array |
There was a problem hiding this comment.
In which case(s) does imageio not return a 'proper' array?
import imageio.v3 as iio
im = iio.imread('https://github.com/datacarpentry/image-processing/raw/main/episodes/data/colonies-01.tif')
type(im)
# numpy.ndarrayI'm not opposed to keeping imread and imsave as thin wrappers if that's for free, but @lagru was reporting maintenance issues (if I'm not mistaken) because of the plugin parameter not meaning the same thing in imageio's functions vs ours.
Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, @stefanv had time just after the meeting and we had a quick chat about the notes as well. :)
cc @mkcor, @decorouz