Fix NumPy2 dtype promotion issues in pywt dependent code #7414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmaarrfk
reviewed
May 7, 2024
hmaarrfk
approved these changes
May 7, 2024
Comment on lines
+791
to
+793
| out = pywt.waverecn(denoised_coeffs, wavelet)[original_extent] | ||
| out = out.astype(image.dtype) | ||
| return out |
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
This reverts commit bfbf88a.
hmaarrfk
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See failures described in #7282 (comment).
Additionally, turn the error raised by pyamg lacking support for NumPy 2 (see pyamg/pyamg#406) into a warning for now.
Checklist
./doc/examplesfor new featuresRelease note
For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.