Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify instructions on changelist in PR template #7401

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

lagru
Copy link
Member

@lagru lagru commented Apr 18, 2024

Description

I noticed that several contributors struggled with interpreting these instructions properly. So rather than making them attempt something they are not familiar with, let's make it clear that we don't expect them to fill this out.

Also remove the newlines. It seems that GitHub now (?) preserves newlines even within paragraphs. Can't find any news on this but I'm sure that this wasn't the previous behavior...

Checklist

Release note

We use changelist to
compile each pull request into an item of the release notes. Please refer to
the instructions
and past release notes
for guidance and examples.

...

I noticed that several contributors struggled with interpreting these
instructions properly. So rather than making them attempt something they
are not familiar with, let's make it clear that we don't expect them to
fill this out.

Also remove the newlines. It seems that GitHub now (?) preserves
newlines even within paragraphs. Can't find any news on this but I'm
sure that this wasn't the previous behavior...
@lagru lagru added 🤖 type: Infrastructure CI, packaging, tools and automation 🚀 Quick win Trivial, small or easy to address or review labels Apr 18, 2024
@mkcor mkcor merged commit b5f2ee9 into scikit-image:main Apr 18, 2024
22 checks passed
@stefanv stefanv added this to the 0.23.2 milestone Apr 18, 2024
@lagru lagru deleted the patch-pr-template branch April 18, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 type: Infrastructure CI, packaging, tools and automation 🚀 Quick win Trivial, small or easy to address or review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants