Ignore Sphinx warning about unpickable cache #7400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Sphinx 7.3.0][1] introduce a new warning about not being able to pickle a config value. I think the function `plotly_sg_scraper` in `sphinx_gallery_conf` is triggering this. If I read azure-pipelines.yml correctly we are not preserving Sphinx's cache between runs anyway. So we should be fine to just ignore this warning. These new [config options][2] also require Sphinx 7.3.0. [1]: https://www.github.com/sphinx-doc/sphinx/issues/12300 [2]: https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-show_warning_types
lagru
changed the title
jarrodmillman
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes our failing Windows CI, e.g. #20240417.3 • Add out-of-tree Pyodide builds in CI for
scikit-image.Sphinx 7.3.0 introduced a new warning about not being able to pickle a config value. I think the function
plotly_sg_scraperinsphinx_gallery_confis triggering this. If I read azure-pipelines.yml correctly we are not preserving Sphinx's cache between runs anyway. So we should be fine to just ignore this warning. See also sphinx-doc/sphinx#12300.These new config options also require Sphinx 7.3.0.
Checklist
./doc/examplesfor new featuresRelease note
We use changelist to compile each pull request into an item of the release notes. Please refer to the instructions and past release notes for guidance and examples.