Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix download-artifact@v4 error #7396

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix download-artifact@v4 error #7396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9d362b
Revert "Revert to older artifacat uploader and downloader"
jarrodmillman Apr 11, 2024
44a0861
Update wheel workflow artifact names
jarrodmillman Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ jobs:
if: always()
run: cp benchmarks/README_CI.md benchmarks.log .asv/results/

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: always()
with:
name: asv-benchmark-results-${{ runner.os }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
DEPLOY_KEY: ${{ secrets.DOC_DEPLOY_KEY_PRIVATE }}
GIT_SSH_COMMAND: "ssh -o StrictHostKeyChecking=no"
- name: Store docs as artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: docs
path: doc/build/html
5 changes: 3 additions & 2 deletions .github/workflows/nightly_wheel_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,12 @@ jobs:
if: github.repository_owner == 'scikit-image' && github.ref == 'refs/heads/main'
runs-on: ubuntu-latest
steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
id: download
with:
name: wheels
name: skimage-wheels-*
path: ./dist
merge-multiple: true

- name: Upload wheel
uses: scientific-python/upload-nightly-action@b67d7fcc0396e1128a474d1ab2b48aa94680f9fc # 0.5.0
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/wheel_tests_and_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,12 @@ jobs:
run: |
pip install twine

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
id: download
with:
name: wheels
name: skimage-wheels-*
path: ./dist
merge-multiple: true

- name: Build the source distribution
run: |
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/wheels_recipe.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ jobs:
CIBW_MANYLINUX_I686_IMAGE: ${{ matrix.cibw_manylinux }}
CIBW_ENVIRONMENT_PASS_LINUX: SKIMAGE_LINK_FLAGS
SKIMAGE_LINK_FLAGS: "-Wl,--strip-debug"
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: wheels
name: skimage-wheels-${{ matrix.os }}-${{ matrix.cibw_arch }}-${{ strategy.job-index }}
path: ./dist/*.whl

build_linux_aarch64_wheels:
Expand Down Expand Up @@ -99,9 +99,9 @@ jobs:
CIBW_MANYLINUX_I686_IMAGE: ${{ matrix.cibw_manylinux }}
CIBW_ENVIRONMENT_PASS_LINUX: SKIMAGE_LINK_FLAGS
SKIMAGE_LINK_FLAGS: "-Wl,--strip-debug"
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: wheels
name: skimage-wheels-${{ matrix.os }}-${{ matrix.cibw_arch }}-${{ strategy.job-index }}
path: ./dist/*.whl

build_macos_wheels:
Expand Down Expand Up @@ -177,9 +177,9 @@ jobs:
CIBW_MANYLINUX_I686_IMAGE: manylinux1
CIBW_TEST_SKIP: "*-macosx_arm64"

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: wheels
name: skimage-wheels-${{ matrix.os }}-${{ matrix.cibw_arch }}-${{ strategy.job-index }}
path: ./dist/*.whl

build_windows_wheels:
Expand Down Expand Up @@ -235,7 +235,7 @@ jobs:
# -Wl,-S equivalent to gcc's -Wl,--strip-debug
LDFLAGS: "-Wl,-S"

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: wheels
name: skimage-wheels-${{ matrix.os }}-${{ matrix.cibw_arch }}-${{ strategy.job-index }}
path: ./dist/*.whl