Ignore arch specific cast warnings originating from astype in tests
#7393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently astype(...) raises a warning on some platforms despite `casting="unsafe"` being the default. I couldn't reproduce this as I don't have access to the architectures this fails for [1, 2], but these warnings should be harmless to ignore for these tests. [1] https://www.github.com/scikit-image/scikit-image/issues/7391 [2] https://buildd.debian.org/status/logs.php?pkg=skimage&ver=0.23.1-1&suite=sid
lagru
added
馃敡 type: Maintenance
jarrodmillman
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #7391.
Apparently
astype(...)raises a warning on some platforms despitecasting="unsafe"being the default. I couldn't reproduce this as I don't have access to the architectures this fails for [1]. Ideally, we could adapt the tests in a way that doesn't raise these warnings but I don't really care for debugging these remotely when these warnings are hopefully harmless to ignore. 馃[1] https://buildd.debian.org/status/logs.php?pkg=skimage&ver=0.23.1-1&suite=sid
Checklist
./doc/examplesfor new featuresRelease note
We use changelist to compile each pull request into an item of the release notes. Please refer to the instructions and past release notes for guidance and examples.