Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date to 0.23.1 release notes #7384

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

lagru
Copy link
Member

@lagru lagru commented Apr 11, 2024

Description

Just making it consistent with the other notes and adding a note of the task to our release instructions.

Checklist

Release note

We use changelist to
compile each pull request into an item of the release notes. Please refer to
the instructions
and past release notes
for guidance and examples.

...

and make note of the task in the release instructions.
@lagru lagru added 📄 type: Documentation Updates, fixes and additions to documentation 🚀 Quick win Trivial, small or easy to address or review labels Apr 11, 2024
@lagru
Copy link
Member Author

lagru commented Apr 11, 2024

Can't really explain why the version bumb earlier is happily using np.infty without a deprecation warning while the doc build for this PR is failing because of it only 16 hours later.

Only dependency that changed between jobs is idna, from 3.6 to 3.7.

Fix should be simple though.

@lagru
Copy link
Member Author

lagru commented Apr 11, 2024

Only dependency that changed between jobs is idna, from 3.6 to 3.7.

Ah, that statement is wrong. After the tests, before installing the docs there's another call to pip install which pulled in NumPy 1.26.4 previously and is now using NumPy 2.0.0rc1. I think that's because of Pandas.

Addressed in #7386.

@jarrodmillman jarrodmillman merged commit 0aaf7e6 into scikit-image:main Apr 11, 2024
22 checks passed
@stefanv stefanv added this to the 0.24 milestone Apr 11, 2024
@lagru lagru deleted the add-date-0.23.1-release-notes branch April 11, 2024 15:14
@jarrodmillman jarrodmillman modified the milestones: 0.24, 0.23.2 Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 type: Documentation Updates, fixes and additions to documentation 🚀 Quick win Trivial, small or easy to address or review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants